Re: [PATCH v11 31/65] dyndbg: add DYNAMIC_DEBUG_CLASSMAP_USE_(dd_class_name, offset)

[Louis Chauvet]

On Fri, 13 Mar 2026 07:19:56 -0600, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
> [...]
> cases; perhaps a 3-X-3 of classmap-defns X classmap-users would get
> too awkward and fiddly.
> 
> This is an untested interface extension, so drop this patch if it
> feels too speculative, knowing theres at least a notional solution
> should the situation arise.

I agree on the patch principle, the implementation seems good.

Can you move this patch after the BROKEN removal? I think you should
"stabilize" core features first so we can merge part of the series (and
reduce patch count).

>
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index e9fa0c8868db..2083a8546460 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -206,12 +206,17 @@ ddebug_find_valid_class(struct _ddebug_info const *di, const char *query_class,
>  	return NULL;
>  }
>  
> -static bool ddebug_class_in_range(const int class_id, const struct _ddebug_class_map *map)
> +static bool ddebug_class_map_in_range(const int class_id, const struct _ddebug_class_map *map)

(that the rename I mentionned earlier)

-- 
Louis Chauvet <louis.chauvet@xxxxxxxxxxx>