RE: [PATCH v5 08/15] irqchip/renesas-rzg2l: Split rzfive_tint_irq_endisable() into separate IRQ and TINT helpers

[Biju Das]

Hi Thomas,

Thanks for the feedback.

> -----Original Message-----
> From: Thomas Gleixner <tglx@xxxxxxxxxx>
> Sent: 20 March 2026 08:51
> Subject: Re: [PATCH v5 08/15] irqchip/renesas-rzg2l: Split rzfive_tint_irq_endisable() into separate
> IRQ and TINT helpers
> 
> On Wed, Mar 11 2026 at 19:24, Biju wrote:
> > +static void rzfive_tint_endisable(struct irq_data *d, bool enable) {
> > +	struct rzg2l_irqc_priv *priv = irq_data_to_priv(d);
> > +	unsigned int hwirq = irqd_to_hwirq(d);
> > +
> 
> stray newline/ The previous comment about data types applies here too.

My bad.

> 
> > +	u32 offset = hwirq - IRQC_TINT_START;
> > +	u32 tssr_offset = TSSR_OFFSET(offset);
> > +	u8 tssr_index = TSSR_INDEX(offset);
> > +	u32 reg;
> > +
> > +	raw_spin_lock(&priv->lock);
> 
>   guard()

Agreed will use guard().

Cheers,
Biju