Re: [PATCH v4 2/2] nvme-auth: Don't propose NVME_AUTH_DHGROUP_NULL with SC_C

[Chris Leech]

On Fri, Mar 20, 2026 at 10:20:45AM +1000, alistair23@xxxxxxxxx wrote:
> From: Alistair Francis <alistair.francis@xxxxxxx>
> 
> Section 8.3.4.5.2 of the NVMe 2.1 base spec states that
> 
> """
> The 00h identifier shall not be proposed in an AUTH_Negotiate message
> that requests secure channel concatenation (i.e., with the SC_C field
> set to a non-zero value).
> """
> 
> We need to ensure that we don't set the NVME_AUTH_DHGROUP_NULL idlist if
> SC_C is set.
> 
> Signed-off-by: Kamaljit Singh <kamaljit.singh@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Looks good.

Reviewed-by: Chris Leech <cleech@xxxxxxxxxx>