Re: [PATCH v2 0/3] drm/imagination: Firmware handling of context reset notification

[Matt Coster]

On 12/03/2026 11:40, Alexandru Dadu wrote:
> - patch 1: Adds missing context reset reasons.
> - patch 2: Fixes the reset_reason from enum to u32 in the fwif.
> - patch 3: Adds the implementation of the context reset notification.
> 
> Signed-off-by: Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>

Just one minor nit (P2 still has the extra blank line between the git
tags) but I can fix that when applying so:

Reviewed-by: Matt Coster <matt.coster@xxxxxxxxxx>

I'll apply this to drm-misc-next shortly if there's no opposition.

Cheers,
Matt

> ---
> Changes in v2:
> - enum rogue_context_reset_reason update moved to a separate commit;
> - pvr_context_reset_notification() renamed to pvr_dump_context_reset_notification();
> - added handling for PVR_FWIF_DM_TDM;
> - update include order in pvr_dump.c;
> - fixed enum type ambiguilty in fwif headers for the reset_reason struct field;
> - small QOL and nits fixed.
> - Link to v1: https://lore.kernel.org/r/20260305-b4-firmware-context-reset-notification-handling-v1-1-46e2ce8d46ef@xxxxxxxxxx
> 
> ---
> Alexandru Dadu (3):
>       drm/imagination: Add missing rogue context reset reasons
>       drm/imagination: Switch reset_reason fields from enum to u32
>       drm/imagination: Implement handling of context reset notification
> 
>  drivers/gpu/drm/imagination/Makefile               |   1 +
>  drivers/gpu/drm/imagination/pvr_ccb.c              |   5 +
>  drivers/gpu/drm/imagination/pvr_dump.c             | 113 +++++++++++++++++++++
>  drivers/gpu/drm/imagination/pvr_dump.h             |  17 ++++
>  drivers/gpu/drm/imagination/pvr_rogue_fwif.h       |   8 +-
>  .../gpu/drm/imagination/pvr_rogue_fwif_shared.h    |  18 +++-
>  6 files changed, 159 insertions(+), 3 deletions(-)
> ---
> base-commit: d2e20c8951e4bb5f4a828aed39813599980353b6
> change-id: 20260305-b4-firmware-context-reset-notification-handling-694a1b5e6b8c
> 
> Best regards,
> --
> Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
> 


-- 
Matt Coster
E: matt.coster@xxxxxxxxxx

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature