Re: [PATCH RFC v2 1/9] dt-bindings: iio: frequency: add ad9910

From: Conor.Dooley

Date: Fri Mar 20 2026 - 10:04:19 EST


On 20/03/2026 11:21, Rodrigo Alencar wrote:

>>> +dependencies:
>>> + adi,charge-pump-current-microamp: [ 'adi,pll-enable' ]
>>> + adi,refclk-out-drive-strength: [ 'adi,pll-enable' ]
>>> + interrupts: [ interrupt-names ]
>>> + clocks: [ clock-names ]
>>> + '#clock-cells': [ clock-output-names ]
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - clocks
>>
>> Worth pointing out, you haven't made either clock-names or
>> interrupt-names (when interrupts are used) mandatory, so the properties
>> cannot be used by a driver. I suggest you make clock-names mandatory and
>> interrupts depend on interrupt-names.
>
> the dependecies is not enought make them required then? understood!

lol, clearly I am blind.