Re: [PATCH v3 1/3] dt-bindings: dma: arm-dma350: document generic and combined IRQ topologies

[Jun Guo]

On 3/20/2026 5:12 PM, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On Thu, Mar 19, 2026 at 06:17:21PM +0800, Jun Guo wrote:
> > Update the DMA-350 DT binding to match the current driver behavior.
> >
> > Allow both:
> > - "arm,dma-350" as the generic compatible, and
> > - "cix,sky1-dma-350", "arm,dma-350" for SoC-specific fallback usage.
> >
> > Also document interrupt topology variants supported by hardware
> > integration:
> > - one combined interrupt for all channels, or
> > - one interrupt per channel (up to 8 channels).
> >
> > This patch is Assisted-by: Cursor: GPT-5.3 Codex.
>
> Wrong tag, please read carefully the guideline before using LLM tools.
Okay. I will temporarily disregard the check patch warnings in the next 
version and correct the format of the AI-generated tag.

> > Signed-off-by: Jun Guo <jun.guo@xxxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20251216123026.3519923-2-jun.guo@xxxxxxxxxxx
>
> What does this express? Changelog link? Then keep it in the changelog
> --- part.
Okay, I'll address this in the next version of the patch.

> > ---
> >   .../devicetree/bindings/dma/arm,dma-350.yaml  | 31 +++++++++++++------
> >   1 file changed, 21 insertions(+), 10 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> > index 429f682f15d8..3639ce0d5054 100644
> > --- a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> > +++ b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> > @@ -14,7 +14,11 @@ allOf:
> >
> >   properties:
> >     compatible:
> > -    const: arm,dma-350
> > +    oneOf:
> > +      - const: arm,dma-350
> > +      - items:
> > +          - const: cix,sky1-dma-350
> > +          - const: arm,dma-350
> >
> >     reg:
> >       items:
> > @@ -22,15 +26,22 @@ properties:
> >
> >     interrupts:
> >       minItems: 1
> > -    items:
> > -      - description: Channel 0 interrupt
> > -      - description: Channel 1 interrupt
> > -      - description: Channel 2 interrupt
> > -      - description: Channel 3 interrupt
> > -      - description: Channel 4 interrupt
> > -      - description: Channel 5 interrupt
> > -      - description: Channel 6 interrupt
> > -      - description: Channel 7 interrupt
> > +    maxItems: 8
> > +    description: |
> > +      The DMA controller may be configured with separate interrupts for each channel,
> > +      or with a single combined interrupt for all channels, depending on the SoC integration.
>
> And more important - you must review the LLM microslop output before
> posting and adjust it to Linux kernel coding style. Don't send
> unredacted tool output.
Actually, this part of the description was not AI-generated. However, 
I’d like to confirm the issue you mentioned: are you saying that this 
description is written too verbosely?
Then, do you think there are still issues with the revised version?
  interrupts:
    minItems: 1
    maxItems: 8
    description:
      Either one interrupt per channel (8 interrupts), or one
      combined interrupt for all channels.

> Best regards,
> Krzysztof