Re: [PATCH] dt-bindings: mmc: mtk-sd: add mediatek,mt8183-mmc fallback to mediatek,mt8189-mmc
From: AngeloGioacchino Del Regno
Date: Fri Mar 20 2026 - 04:31:05 EST
Il 19/03/26 21:36, David Lechner ha scritto:
Change mediatek,mt8189-mmc to include mediatek,mt8183-mmc as a fallback
compatible.
This has been tested using U-Boot and the MMC is still working using the
mediatek,mt8183-mmc fallback compatible, so they seem to be compatible
enough. And there are no upstream users of mediatek,mt8189-mmc yet, so
this should not be a breaking change.
Devicetree describes hardware. This hardware IP is *not* compatible with the one
found in MT8183, as it is a different revision.
Luck wants that there weren't too many breaking changes, and that whatever does
change may need some more bits to activate before breaking, but describing this
as compatible with MT8183 is wrong, because ... it's not.
Sorry, but... NACK.
Regards,
Angelo
Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
---
Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index eb3755bdfdf7..9160e449aeb9 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -25,7 +25,6 @@ properties:
- mediatek,mt8135-mmc
- mediatek,mt8173-mmc
- mediatek,mt8183-mmc
- - mediatek,mt8189-mmc
- mediatek,mt8196-mmc
- mediatek,mt8516-mmc
- items:
@@ -36,6 +35,7 @@ properties:
- mediatek,mt6893-mmc
- mediatek,mt8186-mmc
- mediatek,mt8188-mmc
+ - mediatek,mt8189-mmc
- mediatek,mt8192-mmc
- mediatek,mt8195-mmc
- mediatek,mt8365-mmc
---
base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900
change-id: 20260319-mtk-mmc-mt8189-compatible-a62da7c5dd7e
Best regards,
--
David Lechner <dlechner@xxxxxxxxxxxx>