Re: [PATCH v4 1/2] nvme: Add the DHCHAP maximum HD IDs

[yunje shin]

On Fri, Mar 20, 2026 at 9:21 AM <alistair23@xxxxxxxxx> wrote:
>
> From: Alistair Francis <alistair.francis@xxxxxxx>
>
> In preperation for using DHCHAP length in upcoming host and target
> patches let's add the hash and diffie-hellman ID length macros.
>
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> ---
> v4:
>  - New patch
>
>  include/linux/nvme.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 655d194f8e72..b9d3dbe2564d 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -2332,4 +2332,8 @@ enum nvme_pr_change_ptpl {
>
>  #define NVME_PR_IGNORE_KEY (1 << 3)
>
> +/* Section 8.3.4.5.2 of the NVMe 2.1 */
> +#define NVME_AUTH_DHCHAP_MAX_HASH_IDS 30
> +#define NVME_AUTH_DHCHAP_MAX_DH_IDS 30
> +
>  #endif /* _LINUX_NVME_H */
> --
> 2.53.0
>

Looks good to me.

Reviewed-by: Yunje Shin <ioerts@xxxxxxxxxxxxx>