Re: [PATCH v2] nvmet: auth: validate dhchap id list lengths
From: Christoph Hellwig
Date: Fri Mar 20 2026 - 03:50:00 EST
On Wed, Mar 18, 2026 at 01:55:13AM +0900, yunje shin wrote:
> Regarding the local variable — I understand the readability concern,
> but data->auth_protocol[0].dhchap is currently used without a local
> variable in 8 places in target/fabrics-cmd-auth.c (lines 42-44, 71,
> 75-76, 100-101) and 12 places in host/auth.c (lines 145-156).
> Adding one only for the bounds check felt inconsistent, so I kept
> the existing style. Happy to hear your thoughts on this.
Bonus points for fixing all of them up :)