Re: [PATCH v12 0/7] i2c: xiic: use generic device property accessors

[Abdurrahman Hussain]

Hi Andi,

I'm just following up on this patch series (v12) aimed at updating the xiic
driver to use generic device property accessors.

I addressed the feedback from Krzysztof and Andy in this version. Do you
have any updates or further comments on this series? I am happy to make
any necessary changes.

Thank you,
Abdurrahman

Link to patchwork: https://patchwork.ozlabs.org/project/linux-i2c/list/?series=493003

> On Feb 23, 2026, at 7:59 AM, Abdurrahman Hussain via B4 Relay <devnull+abdurrahman.nexthop.ai@xxxxxxxxxx> wrote:
> 
> - Switch to generic device property accessors.
> - Switch to managed devm_ functions to simplify error handling.
> - General cleanups.
> - Skip clock setup on non-OF systems where clock is not specified via
> firmware.
> 
> Signed-off-by: Abdurrahman Hussain <abdurrahman@xxxxxxxxxx>
> ---
> Changes in v12:
> - Reworded the patch 3 description as suggested by Krzysztof.
> - Added fwnode to patch 3 as suggested by Andy.
> - Used fwnode added in patch 3 in patch 7 as suggested by Andy.
> - Link to v11: https://lore.kernel.org/r/20260213-i2c-xiic-v11-0-5d18aea11bde@xxxxxxxxxx
> 
> Changes in v11:
> - Cosmetic change to return 0 in patch 1.
> - Remove pm_runtime_dont_use_autosuspend() in patch 1.
> - Link to v10: https://lore.kernel.org/r/20260204-i2c-xiic-v10-0-c2b996425235@xxxxxxxxxx
> 
> Changes in v10:
> - Moved dev_dbg() change from patch 4 to patch 5.
> - Reworded description in patch 6.
> - Addressed Andy's comment in patch 7 (&pdev->dev -> dev).
> - Link to v9: https://lore.kernel.org/r/20260202-i2c-xiic-v9-0-ce4695f5267d@xxxxxxxxxx
> 
> Changes in v9:
> - Fix an issue found by the test robot in the cleanup patch.
> - Reworded the clock change description.
> - Add a patch to switch to i2c_add_numbered_adapter().
> - Link to v8: https://lore.kernel.org/r/20260201-i2c-xiic-v8-0-deb2dd158d1a@xxxxxxxxxx
> 
> Changes in v8:
> - Made the clock change the last patch in the series.
> - Reworded the clock change description.
> - Changed dev->fwnode to dev_fwnode(dev).
> - Link to v7: https://lore.kernel.org/r/20260129-i2c-xiic-v7-0-727e434897ef@xxxxxxxxxx
> 
> Changes in v7:
> - Drop the dt-bindings patch.
> - Skip clock setup on non-OF systems.
> - Minor commit body rewording.
> - Applied code-review trailers with `b4 trailers -u`
> - Link to v6: https://lore.kernel.org/r/20260127-i2c-xiic-v6-0-e82e2f6f657c@xxxxxxxxxx
> 
> Changes in v6:
> - Cosmetic changes to address the comments.
> - Added a patch to use resource format specifier in debug log.
> - Link to v5: https://lore.kernel.org/r/20260126-i2c-xiic-v5-0-88a16a28721c@xxxxxxxxxx
> 
> Changes in v5:
> - Reorder the cosmetic patch to be the last in the series.
> - Added a documentation patch to describe the optional clock.
> - Minor commit body rewording.
> - Link to v4: https://lore.kernel.org/r/20260123-i2c-xiic-v4-0-4a3eba3510ce@xxxxxxxxxx
> 
> Changes in v4:
> - Reorder the cosmetic patch to be the first in the series.
> - Amend the mutex_init patch to also switch to the managed pm_runtime_
>  variant.
> - Link to v3: https://lore.kernel.org/r/20260123-i2c-xiic-v3-0-eb7cd4254dfb@xxxxxxxxxx
> 
> Changes in v3:
> - Reorder the "optional clock" patch to be the first in the series. 
> - Add a patch to switch to devm_mutex_init().
> - Remove dup message in error path.
> - Cosmetic: use temporary dev variable.
> - Link to v2: https://lore.kernel.org/r/20260122-i2c-xiic-v2-0-134f5d743e8b@xxxxxxxxxx
> 
> Changes in v2:
> - Split the patch into two independent changes.
> - Added struct device *dev at the top of probe() and remove() to re-use.
> - Switched to device_set_node(...)
> 
> ---
> Abdurrahman Hussain (7):
>      i2c: xiic: switch to devres managed APIs
>      i2c: xiic: remove duplicate error message
>      i2c: xiic: switch to generic device property accessors
>      i2c: xiic: cosmetic cleanup
>      i2c: xiic: cosmetic: use resource format specifier in debug log
>      i2c: xiic: use numbered adapter registration
>      i2c: xiic: skip input clock setup on non-OF systems
> 
> drivers/i2c/busses/i2c-xiic.c | 97 +++++++++++++++++++------------------------
> 1 file changed, 42 insertions(+), 55 deletions(-)
> ---
> base-commit: 37a93dd5c49b5fda807fd204edf2547c3493319c
> change-id: 20260122-i2c-xiic-3ba89ff5ea93
> 
> Best regards,
> -- 
> Abdurrahman Hussain <abdurrahman@xxxxxxxxxx>
> 
>