Re: [PATCH v2 3/3] arm64: dts: qcom: Add Mahua SoC and CRD

[Dmitry Baryshkov]

On Fri, Mar 20, 2026 at 04:37:16AM +0200, Dmitry Baryshkov wrote:
> On Wed, Mar 18, 2026 at 05:41:00AM -0700, Gopikrishna Garmidi wrote:
> > Introduce support for the Mahua SoC and the CRD based on it. Some of
> > the notable differences are the absent CPU cluster, interconnect, TLMM,
> > thermal zones and adjusted PCIe west clocks. Everything else should
> > work as-is.
> > 
> > Co-developed-by: Raviteja Laggyshetty <raviteja.laggyshetty@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile            |   1 +
> >  arch/arm64/boot/dts/qcom/glymur.dtsi         |   2 +-
> >  arch/arm64/boot/dts/qcom/mahua-crd.dts       |  21 ++
> >  arch/arm64/boot/dts/qcom/mahua.dtsi          | 299 +++++++++++++++++++
> >  arch/arm64/boot/dts/qcom/pmcx0102.dtsi       |   2 +-
> >  arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi |   4 +-
> >  6 files changed, 325 insertions(+), 4 deletions(-)
> >  create mode 100644 arch/arm64/boot/dts/qcom/mahua-crd.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/mahua.dtsi
> 
> 
> As a second thought, patching the nodes using node names is frowned
> upon. I've implemented the similar change for Hamoa/Purwa pair, but I
> ended up defining thermal_foo labels for all affected (removed or
> patched) nodes and then patching them using that label.
> 
> Would it make sense to implement a similar change here?

NVM, the patch was merged, I'll send a separate followup.

> 
> > +
> 

-- 
With best wishes
Dmitry