Re: [PATCH] perf/x86/intel/p4: Fix unused variable warning in p4_pmu_init()

From: Dave Hansen

Date: Thu Mar 19 2026 - 18:27:45 EST


On 3/19/26 15:20, Aldo Conte wrote:
> I admit I'm a novice in this field, so what do you suggest is the best
> fix at this point?
> Should I use the “warning suppressor" with something like
>     (void) val1 = (u32)_l;                \
>     (void) val2 = _l >> 32;            \
> or implement the solution you suggested?

Ideally, someone should go consolidate the two copies.

But, for now, for the p4.c issue, I'm still happy with transitioning
over to rdmsrq().