Re: [PATCH v2] blk-mq: add tracepoint block_rq_tag_wait

[Steven Rostedt]

On Wed, 18 Mar 2026 21:53:00 -0400
Aaron Tomlin <atomlin@xxxxxxxxxxx> wrote:

> +	TP_fast_assign(
> +		__entry->dev		= disk_devt(q->disk);
> +		__entry->hctx_id	= hctx->queue_num;
> +		__entry->is_sched_tag	= is_sched_tag;
> +
> +		if (__entry->is_sched_tag)

Nit, but why use __entry->is_sched_tag instead of is_sched_tag.

Not sure if the compiler will optimize it (likely it will), but it seems
cleaner to use the variable directly and not the one assigned.

Perhaps the compiler is smart enough to use one register for both updates.

-- Steve


> +			__entry->nr_tags = hctx->sched_tags->nr_tags;
> +		else
> +			__entry->nr_tags = hctx->tags->nr_tags;
> +	),
> +