Re: [PATCH v8 3/3] mmc: sdhci-esdhc-imx: remove redundant mx25 handling and consolidate soc data
From: Fabio Estevam
Date: Thu Mar 19 2026 - 16:42:10 EST
On Thu, Mar 19, 2026 at 5:10 PM Adrián García Casado
<adriangarciacasado42@xxxxxxxxx> wrote:
> @@ -873,11 +865,8 @@ static void esdhc_writeb_le(struct sdhci_host *host, u8 val, int reg)
> new_val = val & SDHCI_CTRL_LED;
> /* ensure the endianness */
> new_val |= ESDHC_HOST_CONTROL_LE;
> - /* bits 8&9 are reserved on mx25 */
> - if (!is_imx25_esdhc(imx_data)) {
> - /* DMA mode bits are shifted */
> - new_val |= (val & SDHCI_CTRL_DMA_MASK) << 5;
> - }
This removal of the i.MX25 check does not look correct.