Re: [PATCH] staging: rtl8723bs: break long lines in rtw_sta_mgt.c

From: Ethan Tidmore

Date: Thu Mar 19 2026 - 14:59:05 EST


On Thu Mar 19, 2026 at 12:42 PM CDT, MalavyaRaval wrote:
> The original patch attempted to use the preferred sizeof(*ptr) style,
> but since the target variable is a u8 pointer, this caused a buffer
> overflow. Reverting to sizeof(struct sta_info) ensures the correct
> allocation size while satisfying the line-splitting requirement.
>
> Signed-off-by: MalavyaRaval <malavyaraval@xxxxxxxxx>

You need to put FirstName LastName <email>.

...

> - pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
> + pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
> + NUM_STA + 4);

This just makes the code harder to read.

Thanks,

ET