Re: [PATCH v7 1/3] wifi: iwlwifi: pcie: migrate to modern pci_alloc_irq_vectors API

From: Jeff Johnson

Date: Thu Mar 19 2026 - 14:51:17 EST


On 3/19/2026 11:29 AM, Adrián García Casado wrote:
> Johannes Berg suggested using pci_alloc_irq_vectors() and delegating
> affinity management to the kernel. This patch replaces
> pci_enable_msix_range() with the modern API and leverages
> PCI_IRQ_AFFINITY. The manual affinity loop is removed as it's now
> redundant.

I see from the archive that you've been pointed to this link, but I'm going to
do so again...

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

"Describe your problem. Whether your patch is a one-line bug fix or 5000 lines
of a new feature, there must be an underlying problem that motivated you to do
this work. Convince the reviewer that there is a problem worth fixing and that
it makes sense for them to read past the first paragraph."

"Describe your changes in imperative mood, e.g. “make xyzzy do frotz” instead
of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as
if you are giving orders to the codebase to change its behaviour."