Re: [PATCH v2 0/3] KVM: arm64: Read PMUVer as unsigned

[Marc Zyngier]

On Thu, 05 Mar 2026 16:28:16 +0000,
James Clark <james.clark@xxxxxxxxxx> wrote:
> 
> Fix some issues with the signedness of PMUVer and PerfMon ID fields.
> 
> I ran into the first issue when testing "ARM64 PMU Partitioning" patches
> on the FVP. The second issue was only found by inspection.
> 
> Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
> ---
> Changes in v2:
> - Handle ID_AA64DFR0_EL1_PMUVer_IMP_DEF correctly by using
>   pmuv3_implemented()
> - Fix another issue with incorrect sign in cpufeature.c
> - Add a commit to refactor has_pmuv3() to use pmuv3_implemented() for
>   consistency
> - Link to v1: https://lore.kernel.org/r/20260305-james-kvm-pmuver-sign-v1-1-eea0a2116dd0@xxxxxxxxxx
> 
> ---
> James Clark (3):
>       KVM: arm64: Read PMUVer as unsigned
>       arm64: cpufeature: Make PMUVer and PerfMon unsigned
>       arm64: cpufeature: Use pmuv3_implemented() function
> 
>  arch/arm/include/asm/arm_pmuv3.h |  7 +++++++
>  arch/arm64/kernel/cpufeature.c   | 16 ++++------------
>  arch/arm64/kvm/debug.c           |  5 ++++-
>  3 files changed, 15 insertions(+), 13 deletions(-)

Given that this only tangentially affects KVM, it'd better be routed
via the arm64/perf tree.

With that in mind:

Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx>

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.