Re: [PATCH v4 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver

From: Bryan O'Donoghue

Date: Thu Mar 19 2026 - 09:17:56 EST


On 19/03/2026 13:08, Vladimir Zapolskiy wrote:
Why do you want a media driver? Isn't PHY driver enough?

As for today CAMSS CSIPHY are already media devices, and a user applies media
specific properties to them, for instance media bus format, resolution etc.
Technically this might be removed from CAMSS, but if so, then it should be
done before this new PHY driver model is applied.

--
Best wishes,

There's no reason to remove that from CAMSS - it would be an ABI break in user-space anyway.

The media entity in CAMSS msm_csiphyX handles format negotiation and pipeline routing. The PHY driver handles electrical configuration. They don't conflict and there multiple cited examples of this upstream already.

--
bod