RE: [PATCH v6 03/10] clk: renesas: r9a07g04{3,4}/r9a08g045-cpg: Add critical reset entries

[Biju Das]

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 19 March 2026 13:08
> Subject: Re: [PATCH v6 03/10] clk: renesas: r9a07g04{3,4}/r9a08g045-cpg: Add critical reset entries
> 
> Hi Biju,
> 
> On Thu, 19 Mar 2026 at 13:51, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > The RZ/G2L SoC family requires DMA resets to be deasserted for routing
> > some peripheral interrupts to the CPU. Asserting these resets after
> > boot would silently break interrupt delivery with no driver to restore them.
> >
> > Mark the DMA resets as critical by adding them to the crit_resets
> > table in the SoC-specific rzg2l_cpg_info for r9a07g043, r9a07g044, and
> > r9a08g045, preventing __rzg2l_cpg_assert() from asserting them and
> > ensuring they are deasserted during probe and resume.
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v5->v6:
> >  * Replaced r9a07g043_critical_resets[] -> r9a07g043_crit_resets[] for
> >    consistency
> >  * Collected tag
> 
> Thanks for the update!
> 
> > --- a/drivers/clk/renesas/r9a07g044-cpg.c
> > +++ b/drivers/clk/renesas/r9a07g044-cpg.c
> > @@ -489,6 +489,11 @@ static const unsigned int r9a07g044_crit_mod_clks[] __initconst = {
> >         MOD_CLK_BASE + R9A07G044_DMAC_ACLK,  };
> >
> > +static const unsigned int r9a07g044_critical_resets[] = {
> 
> With "everywhere", of course I meant for all SoCs ;-) No need to resend just for this.

My bad, I missed checking other 2 SoCs.

Cheers,
Biju