Re: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt

[Andre Przywara]

Hi,

On 3/18/26 15:21, kernel test robot wrote:
> Hi Andre,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next rockchip/for-next shawnguo/for-next soc/for-next linus/master nferre-at91/at91-next v7.0-rc4 next-20260317]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Andre-Przywara/dt-bindings-arm-Add-Live-Firmware-Activation-binding/20260318-082717
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link:    https://lore.kernel.org/r/20260317103336.1273582-8-andre.przywara%40arm.com
> patch subject: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt
> config: arm64-randconfig-004-20260318 (https://download.01.org/0day-ci/archive/20260318/202603182202.gpyCz2RF-lkp@xxxxxxxxx/config)
> compiler: aarch64-linux-gcc (GCC) 12.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603182202.gpyCz2RF-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202603182202.gpyCz2RF-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
>     drivers/firmware/smccc/lfa_fw.c: In function 'lfa_register_dt':
> > > drivers/firmware/smccc/lfa_fw.c:878:16: error: implicit declaration of function 'devm_request_threaded_irq'; did you mean 'devm_request_region'? [-Werror=implicit-function-declaration]
>       878 |         return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
>           |                ^~~~~~~~~~~~~~~~~~~~~~~~~
>           |                devm_request_region
> > > drivers/firmware/smccc/lfa_fw.c:880:42: error: 'IRQF_COND_ONESHOT' undeclared (first use in this function)
>       880 |                                          IRQF_COND_ONESHOT, NULL, NULL);
>           |                                          ^~~~~~~~~~~~~~~~~
>     drivers/firmware/smccc/lfa_fw.c:880:42: note: each undeclared identifier is reported only once for each function it appears in
>     drivers/firmware/smccc/lfa_fw.c:881:1: warning: control reaches end of non-void function [-Wreturn-type]
>       881 | }
>           | ^
>     cc1: some warnings being treated as errors

For the records: including <linux/interrupt.h> fixes this issue.

Thanks for the heads up, will add this in a follow-up post.

Cheers,
Andre

> vim +878 drivers/firmware/smccc/lfa_fw.c
>
>     863	
>     864	static int lfa_register_dt(struct device *dev)
>     865	{
>     866		struct device_node *np;
>     867		unsigned int irq;
>     868	
>     869		np = of_find_compatible_node(NULL, NULL, "arm,lfa");
>     870		if (!np)
>     871			return -ENODEV;
>     872	
>     873		irq = irq_of_parse_and_map(np, 0);
>     874		of_node_put(np);
>     875		if (!irq)
>     876			return -ENODEV;
>     877	
>   > 878		return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
>     879						 lfa_irq_handler_thread,
>   > 880						 IRQF_COND_ONESHOT, NULL, NULL);
>     881	}
>     882