Re: [net-next v3 08/12] net: bnxt: Implement software USO

[Pavan Chebbi]

<...>

> +
> +       hdr_len = tso_start(skb, &tso);
> +       mss = skb_shinfo(skb)->gso_size;
> +       total_payload = skb->len - hdr_len;
> +       num_segs = DIV_ROUND_UP(total_payload, mss);
> +
> +       /* Zero the csum fields so tso_build_hdr will propagate zeroes into
> +        * every segment header. HW csum offload will recompute from scratch.
> +        */
> +       udp_hdr(skb)->check = 0;
> +       if (!tso.ipv6)
> +               ip_hdr(skb)->check = 0;
> +
> +       if (unlikely(num_segs <= 1))
> +               return NETDEV_TX_OK;

goto drop would be more appropriate?

> +

<...>

> +       if (unlikely(bnxt_tx_avail(bp, txr) <= bp->tx_wake_thresh))
> +               netif_txq_try_stop(txq, bnxt_tx_avail(bp, txr),
> +                                  bp->tx_wake_thresh);
> +
> +       return NETDEV_TX_OK;
> +
> +drop:
>         dev_kfree_skb_any(skb);
>         dev_core_stats_tx_dropped_inc(bp->dev);
>         return NETDEV_TX_OK;
> --
> 2.52.0
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature