Re: [PATCH] HID: pulsar: add driver for Pulsar gaming mice

[Leo]

Hi,

While this driver looks fine at a glance, this does seem to use the
same protocol as the hid-kysona driver. It might be more appropriate to
extend that driver instead of rolling a new one? The HID identifiers in
hid-ids.h already have a vendor constant for USB_VENDOR_ID_KYSONA,
which takes the same value as this patch's USB_VENDOR_ID_PULSAR.

For context, I was investigating exactly this battery reporting for
another mouse, the ATK VXE R1 SE+. It does seem to use the exact same
protocol; in wired mode, that takes the device ID 3554:F58F, while the
wireless dongle has a device ID of 373B:1085. I plan on sending a patch
to add these IDs after some testing.

Cheers,
Leo