Re: [PATCH] staging: media: atomisp: hmm: remove unnecessary casts
From: Greg KH
Date: Thu Mar 19 2026 - 05:44:13 EST
On Thu, Mar 19, 2026 at 05:36:25PM +0800, Zile Xiong wrote:
> Drop unnecessary casts when accessing vma->vm_private_data.
>
> No functional change.
>
> Signed-off-by: Zile Xiong <xiongzile99@xxxxxxxxx>
> ---
> drivers/staging/media/atomisp/pci/hmm/hmm_bo.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
> index 856561e951a5..68116edda591 100644
> --- a/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
> +++ b/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
> @@ -975,9 +975,7 @@ void hmm_bo_unref(struct hmm_buffer_object *bo)
>
> static void hmm_bo_vm_open(struct vm_area_struct *vma)
> {
> - struct hmm_buffer_object *bo =
> - (struct hmm_buffer_object *)vma->vm_private_data;
> -
> + struct hmm_buffer_object *bo = vma->vm_private_data;
> check_bo_null_return_void(bo);
>
> hmm_bo_ref(bo);
Why did you delete the extra blank line that checkpatch is just going to
ask you to add back again in a future change? :)
thanks,
greg k-h