Re: [PATCH] gpio: scx200: move the header under linux/gpio/
From: Bartosz Golaszewski
Date: Thu Mar 19 2026 - 05:32:41 EST
On Wed, Mar 18, 2026 at 3:25 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Wed, Mar 18, 2026, at 14:48, Bartosz Golaszewski wrote:
> > Headers exposing symbols specific to individual GPIO drivers should all
> > live under linux/gpio/ for consistency. scx200_gpio.h is currently a
> > top-level header directly under linux/. Move it and update all users.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > ---
> > With Acks from relevant maintainers, I can take it through the GPIO
> > tree.
>
> No objections to the change, but I'd point out that while this is a
> driver for gpio registers, it's not a gpiolib driver but rather a
> custom chardev with ioctl interface.
>
Yeah I wasn't sure if we consider linux/gpio/ as a GPIOLIB directory
or just GPIO in general. I figured it may as well be the latter.
Bart
> Since the chip was never as popular as the separate geode/cs553x
> ones, I wonder if there are any users left, maybe Jim has an idea.
>
> If there are users, they might be able to use drivers/gpio/gpio-cs5535.c
> instead, but I have not checked if the two are compatible.
>