Re: [PATCH v5 4/4] phy: qualcomm: add MSM8974 HDMI PHY support

[Konrad Dybcio]

On 3/18/26 6:15 PM, Dmitry Baryshkov wrote:
> On Wed, Mar 18, 2026 at 10:22:08AM +0100, Konrad Dybcio wrote:
>> On 3/14/26 6:06 AM, Dmitry Baryshkov wrote:
>>> From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>>>
>>> Add support for HDMI PHY on Qualcomm MSM8974 / APQ8074 platforms.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>>> ---

[...]

>> I don't know if it's a good direction, but maybe:
>>
>> const unsigned long max_rate = HDMI_8974_VCO_MAX_FREQ / HDMI_8974_COMMON_DIV;
>>
>> clamp(req->rate, max_rate / 6, max_rate)
> 
> Note, it is clamp (min_rate / 6, max_rate)

see, indeed confusing ;)

But I suppose we don't have a better way of specifying that so whatevs

Konrad