Re: [PATCH] staging: rtl8723bs: Rename TrafficTransitionCount to traffic_transition_count
From: Dan Carpenter
Date: Thu Mar 19 2026 - 05:19:12 EST
On Wed, Mar 18, 2026 at 12:59:24PM -0700, Malavya Raval wrote:
> Renaming CamelCase variable to snake_case to align with kernel coding style standards.
>
Line wrap your commit message at 74 characters.
> - if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount > 30/*TrafficTransitionLevel*/)
> - pmlmepriv->LinkDetectInfo.TrafficTransitionCount = 30;
> + if (pmlmepriv->LinkDetectInfo.traffic_transition_count > 30) /* TrafficTransitionLevel */
You moved the comment out of the parentheses? Why? What does the
comment even mean? So many questions. Are we could to keep the
TrafficTransitionLevel name after we renamed TrafficTransitionCount?
Probably sort that out in a patch at the start and then do a rename.
regards,
dan carpenter