Re: [PATCH v2] ASoC: dt-bindings: hisilicon: Convert hi6210 I2S to dt-schema

[Krzysztof Kozlowski]

On Thu, Mar 19, 2026 at 08:51:12AM +0530, Chaitanya Sabnis wrote:
> Convert the Hisilicon hi6210 I2S controller hardware binding from
> legacy plain text to modern YAML dt-schema format.

You need to document here the differences done during conversion with
explanation. You changed the order of DMA entries.

> 
> Signed-off-by: Chaitanya Sabnis  <chaitanya.msabnis@xxxxxxxxx>
> ---
>  .../bindings/sound/hisilicon,hi6210-i2s.txt   | 42 ----------
>  .../bindings/sound/hisilicon,hi6210-i2s.yaml  | 80 +++++++++++++++++++
>  2 files changed, 80 insertions(+), 42 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/hisilicon,hi6210-i2s.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/hisilicon,hi6210-i2s.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/hisilicon,hi6210-i2s.txt b/Documentation/devicetree/bindings/sound/hisilicon,hi6210-i2s.txt
> deleted file mode 100644
> index 7a296784eb37..000000000000
> --- a/Documentation/devicetree/bindings/sound/hisilicon,hi6210-i2s.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -* Hisilicon 6210 i2s controller
> -
> -Required properties:
> -
> -- compatible: should be one of the following:
> -   - "hisilicon,hi6210-i2s"
> -- reg: physical base address of the i2s controller unit and length of
> -   memory mapped region.
> -- interrupts: should contain the i2s interrupt.
> -- clocks: a list of phandle + clock-specifier pairs, one for each entry
> -  in clock-names.
> -- clock-names: should contain following:
> -   - "dacodec"
> -   - "i2s-base"
> -- dmas: DMA specifiers for tx dma. See the DMA client binding,
> -  Documentation/devicetree/bindings/dma/dma.txt
> -- dma-names: should be "tx" and "rx"

...


> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon hi6210 I2S controller
> +
> +maintainers:
> +  - Chaitanya Sabnis <chaitanya.msabnis@xxxxxxxxx>

This should be someone with datasheet or hardware, e.g.: device driver
maintainer or platform maintainer. Unless you have datasheet or
hardware?

> +
> +allOf:
> +  - $ref: dai-common.yaml#

Best regards,
Krzysztof