Re: [PATCH v2] staging: rtl8723bs: remove unnecessary braces in single statement blocks

[Dan Carpenter]

On Wed, Mar 18, 2026 at 10:41:17PM +0100, Oskar Ray-Frayssinet wrote:
> @@ -403,10 +385,8 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_coexist *pBtCoexist)
>  				pBtLinkInfo->bPanExist &&
>  				pBtLinkInfo->bA2dpExist
>  			) {
> -				if (bBtHsOn) {
> -				} else {
> +				if (bBtHsOn)
>  					algorithm = BT_8723B_2ANT_COEX_ALGO_PANEDR_HID;
> -				}

The patch introduces a bug here.

> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index af6cdda8238d..f4b2854bada7 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -25,9 +25,8 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num)
>  
>  	do {
>  		valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);
> -		if (0 == valid) {
> +		if (valid == 0)

Don't do unrelated changes.

>  			read_down = true;
> -		}
>  	} while ((!read_down) && (retry_cnts--));
>  

regards,
dan carpenter