Re: [PATCH] staging: rtl8723bs: Break long lines in rtw_sta_mgt.c

[Luka Gejak]

Hi Malavya,

Thanks for the patch!

I have a concern regarding the first hunk of this change:

> -	pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
> +	pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(*pstapriv->pallocated_stainfo_buf) *
> +						    NUM_STA + 4);					    

You've changed the logic from taking the size of 'struct sta_info' to 
the size of the dereferenced pointer 
'*pstapriv->pallocated_stainfo_buf'.


Firstly: In this driver, 'pallocated_stainfo_buf' is a u8 pointer. This 
means sizeof(*ptr) will return 1, whereas 'struct sta_info' is much 
larger. This will lead to a significantly smaller memory allocation 
than intended and cause a buffer overflow.

If you want to use the preferred 'sizeof(*ptr)' style, you should use 
the pointer that actually represents the structure array, or stick to 
the original 'struct sta_info' and just wrap the line.

Secondly: For a v2, when splitting the line, 'NUM_STA' should be 
vertically aligned with the start of the 'sizeof' expression on the 
line above. Right now, the indentation looks a bit off.

Also, for a v2, please ensure your subject line starts with a lowercase 
letter after the prefix: "staging: rtl8723bs: break long lines..."

Best regards,
Luka Gejak