Re: [PATCH v2] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' from USB host nodes

[Gabor Juhos]

Hi Miquel,

2026. 03. 18. 11:51 keltezéssel, Miquel Raynal írta:

...

>>> When the nodes of the UTMI PHYs has been added to the SoC dtsi by
>>> commit 05d168a56fae ("arm64: dts: marvell: armada-37xx: declare USB2
>>> UTMI PHYs"), the properties has been added to the USB host controller
>>> nodes also. According to the commit message this was intentional,
>>
>> Miquel will confirm that, after speaking with him, it appears to be a
>> mistake rather than an intentional act.
> 
> Indeed, I believe it is a leftover, the property should have been added
> only to the PHY nodes, not the host nodes.
> 
> The sentence above should be: s/intentional/unintentional/, the commit
> messages clearly states that PHY nodes were targeted, not the
> host. Plus, a follow-up commit adds the missing phy properties to the
> hosts, so clearly reaching this syscon through the host node directly
> does not make sense and was not intended.

Sorry, I assumed that it was intentional because the commit message explicitly
mentioned the USB host node.

> Once this single word fixed, you can add my

Will fix it, and send a new version.

> Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Thank you for the review!

Regards,
Gabor