Re: [PATCH 2/2] sched/fair: get this cpu once in find_new_ilb

[Mukesh Kumar Chaurasiya]

On Thu, Mar 19, 2026 at 12:23:14PM +0530, Shrikanth Hegde wrote:
> smp_processor_id() is pointless to fetch in the loop. Move it out.
> No functional change.
> 
> Signed-off-by: Shrikanth Hegde <sshegde@xxxxxxxxxxxxx>
> ---
>  kernel/sched/fair.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 02cca2c7a98d..9e561c1234b2 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -12635,11 +12635,11 @@ static inline int on_null_domain(struct rq *rq)
>   */
>  static inline int find_new_ilb(struct cpumask *cpus)
>  {
> +	int this_cpu = smp_processor_id();
>  	int ilb_cpu;
>  
>  	for_each_cpu(ilb_cpu, cpus) {
> -
> -		if (ilb_cpu == smp_processor_id())
> +		if (ilb_cpu == this_cpu)
>  			continue;
>  
>  		if (idle_cpu(ilb_cpu))
> -- 
> 2.43.0
> 
LGTM

Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@xxxxxxxxx>