Re: [PATCH] staging: rtl8723bs: Reduce indentation in rtw_joinbss_event_prehandle

[Luka Gejak]

Hi Jose,

Thanks for this patch! Refactoring these deeply nested if-statements 
makes the mlme flow much easier to read and maintain.

Functionally, the logic and lock handling look correct. Great catch on 
removing the redundant spin_lock_bh(&pmlmepriv->lock) before the 
function returns. That is a nice optimization of the original flow.

I have two minor notes for a v2:

1. Subject Line: The standard practice for staging is to use a 
lowercase letter after the prefix. It should be: "staging: rtl8723bs: 
reduce indentation..." instead of "Reduce".

2. Comment Typo: In the refactored step s3:
> +	/* s3. find ptarget_wlan & update ptarget_sta after update
> +	 * cur_network only for station mode
> +	 */
The code here is calling rtw_joinbss_update_stainfo(), so the original 
comment "find ptarget_sta" was actually correct. Since ptarget_wlan was 
already found in s1, you might want to revert that word to avoid
confusion.

Best regards,
Luka Gejak