Re: [PATCH 1/1] usb: dwc3: dwc3-generic-plat: Add optional VBUS regulator support

[Chukun Pan]

Hi,

> I mean this is a generic glue driver and not specific to your spacemit
> k1. Some platforms use regulators to drive the vbus (e.g. dwc3 meson)
> while others for internal controller supplies (e.g. dwc3 exynos). Also,

So shouldn't the generic glue driver manage vbus, but rather the Spacemit
USB PHY driver? I don't have any good ideas about the current name.

> if the platform is operating in device mode, there should be no vbus.

Do I need to check if it's in host mode?

> Also do we want to disable the regulator on system suspend? If so, we
> may need a regulator handle.

I'll add it if you think it's necessary.

I'm not quite sure how to do it well, thank
you for taking the time to review.

Thanks,
Chukun