Re: [PATCH v8 net-next 01/11] net/nebula-matrix: add minimum nbl build framework

[Jakub Kicinski]

On Tue, 17 Mar 2026 11:45:18 +0800 illusion.wang wrote:
> 1.Add nbl min build infrastructure for nbl driver.
> 
> 2.Implemented the framework of pci device initialization.

> +============================================================
> +Linux Base Driver for Nebula-matrix M18100-NIC family
> +============================================================

Shouldn't these lines also be the length of the text?

> +Overview:
> +=========
> +M18100-NIC is a series of network interface card for the Data Center Area.
> +
> +The driver supports link-speed 100GbE/25GE/10GE.
> +
> +M18100-NIC devices support MSI-X interrupt vector for each Tx/Rx queue and
> +interrupt moderation.
> +
> +M18100-NIC devices support also various offload features such as checksum offload,
> +Receive-Side Scaling(RSS).
> +
> +Supported PCI vendor ID/device IDs:
> +===================================
> +
> +1f0f:3403 - M18110 Family PF
> +1f0f:3404 - M18110 Lx Family PF
> +1f0f:3405 - M18110 Family BASE-T PF
> +1f0f:3406 - M18110 Lx Family BASE-T PF
> +1f0f:3407 - M18110 Family OCP PF
> +1f0f:3408 - M18110 Lx Family OCP PF
> +1f0f:3409 - M18110 Family BASE-T OCP PF
> +1f0f:340a - M18110 Lx Family BASE-T OCP PF
> +1f0f:340b - M18100 Family PF
> +1f0f:340c - M18100 Lx Family PF
> +1f0f:340d - M18100 Family BASE-T PF
> +1f0f:340e - M18100 Lx Family BASE-T PF
> +1f0f:340f - M18100 Family OCP PF
> +1f0f:3410 - M18100 Lx Family OCP PF
> +1f0f:3411 - M18100 Family BASE-T OCP PF
> +1f0f:3412 - M18100 Lx Family BASE-T OCP PF

Please don't list all the SKUs what's the point. PCIe device DB is 
the place for that.

> +NEBULA-MATRIX ETHERNET DRIVER (nebula-matrix)
> +M:	Illusion.Wang <illusion.wang@xxxxxxxxxxxxxxxxx>
> +M:	Dimon.Zhao <dimon.zhao@xxxxxxxxxxxxxxxxx>
> +M:	Alvin.Wang <alvin.wang@xxxxxxxxxxxxxxxxx>
> +M:	Sam Chen <sam.chen@xxxxxxxxxxxxxxxxx>

What makes Sam Chen not have a dot in between name and surname?
Maybe let's use the more usual notation and remove the dots?

> +L:	netdev@xxxxxxxxxxxxxxx
> +S:	Maintained
> +F:	Documentation/networking/device_drivers/ethernet/nebula-matrix/*

Why the star at the end?

> +++ b/drivers/net/ethernet/nebula-matrix/nbl/Makefile
> @@ -0,0 +1,10 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2025 Nebula Matrix Limited.
> +
> +obj-$(CONFIG_NBL) := nbl.o
> +
> +nbl-objs +=      nbl_main.o
> +
> +# Provide include files
> +ccflags-y += -I$(srctree)/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/
> +ccflags-y += -I$(srctree)/drivers/net/ethernet/nebula-matrix/nbl/

Why? You really shouldn't need this

> diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h b/drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h
> new file mode 100644
> index 000000000000..8c50904b9151
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2025 Nebula Matrix Limited.
> + */
> +
> +#ifndef _NBL_CORE_H_
> +#define _NBL_CORE_H_
> +
> +enum {
> +	NBL_CAP_HAS_CTRL_BIT = BIT(0),

each header should be self-contained, you haven't included bits.h

> +	NBL_CAP_HAS_NET_BIT = BIT(1),
> +	NBL_CAP_IS_NIC_BIT = BIT(2),
> +	NBL_CAP_IS_LEONIS_BIT = BIT(3),
> +};
> +
> +#endif
> diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_include.h b/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_include.h
> new file mode 100644
> index 000000000000..914f1418f508
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_include.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2025 Nebula Matrix Limited.
> + */
> +
> +#ifndef _NBL_INCLUDE_H_
> +#define _NBL_INCLUDE_H_
> +
> +/*  ------  Basic definitions  -------  */
> +#define NBL_DRIVER_NAME					"nbl"
> +
> +struct nbl_func_caps {
> +	u32 has_ctrl:1;

ditto, types.h

> +	u32 has_net:1;
> +	u32 is_nic:1;
> +	u32 rsv:29;
> +};
> +
> +#endif
> diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c b/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c
> new file mode 100644
> index 000000000000..c0b01fea2548
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c
> @@ -0,0 +1,112 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2025 Nebula Matrix Limited.
> + */
> +
> +#include <linux/device.h>
> +#include <linux/pci.h>
> +#include "nbl_include.h"
> +#include "nbl_core.h"
> +
> +static int nbl_probe(struct pci_dev *pdev,
> +		     const struct pci_device_id __always_unused *id)

__always_unused should be after the arg name, not the type
but also why? kernel build doesn't warn about unused args

> +{
> +	return 0;
> +}

> +MODULE_DEVICE_TABLE(pci, nbl_id_table);
> +
> +static struct pci_driver nbl_driver = {
> +	.name = NBL_DRIVER_NAME,
> +	.id_table = nbl_id_table,
> +	.probe = nbl_probe,
> +	.remove = nbl_remove,
> +};
> +
> +module_pci_driver(nbl_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Nebula Matrix Network Driver");

missing include module.h ..
-- 
pw-bot: cr