Re: [PATCH] scripts/decodecode: Return 0 on success

[Randy Dunlap]

On 3/18/26 10:55 AM, Andrew Morton wrote:
> On Wed, 18 Mar 2026 15:05:45 +0000 Patrick Bellasi <derkling@xxxxxxxxxx> wrote:
> 
>> The decodecode script always returns an exit code of 1, regardless of
>> whether the operation was successful or not. This is because the
>> "cleanup" function, which is registered to run on any script exit via
>> "trap cleanup EXIT", contains an unconditional "exit 1".

Who would do that? and why?  ;)

>> Remove the "exit 1" from the "cleanup" function so that it only performs
>> the necessary file cleanup without forcing a non-zero exit status.
>>
>> Do that to ensure successful script executions now exit with code 0.
>> Exits due to errors are all handled by the "die()" function and will
>> still correctly exit with code 1.
>>
>> ...
>>
>> --- a/scripts/decodecode
>> +++ b/scripts/decodecode
>> @@ -12,7 +12,6 @@ faultlinenum=1
>>  
>>  cleanup() {
>>  	rm -f $T $T.s $T.o $T.oo $T.aa $T.dis
>> -	exit 1
>>  }
>>  
>>  die() {
>> @@ -49,7 +48,7 @@ done
>>  
>>  if [ -z "$code" ]; then
>>  	rm $T
>> -	exit
>> +	die "Code line not found"
>>  fi
>>  
>>  echo $code
> 
> Seems reasonable.  Randy added this in 2008 - I'm sure he can remember
> why ;)

Thanks, Andrew. NFI.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks for the patch.

-- 
~Randy