Re: [PATCH v2 0/2] hwmon: (pmbus) Follow-up fixes for isl68137 and ina233

[Guenter Roeck]

On 3/18/26 12:40, Pradhan, Sanman wrote:
> From: Sanman Pradhan <psanman@xxxxxxxxxxx>
>
> This series provides follow-up fixes for the PMBus error handling series.
>
> Patch 1 is a revised version of the previous isl68137 patch. It restores
> the original bitmask logic for AVS enable reporting while retaining the
> modernization to sysfs_emit() and the new error check.
>
> Patch 2 is an incremental fix for the ina233 driver. It ensures that
> negative shunt voltages read from MFR_READ_VSHUNT are correctly
> sign-extended before being scaled, addressing a data integrity issue
> identified during the previous review.

I applied the first patch of the series, but Sashiko found more problems.
Please have a look at
https://sashiko.dev/#/patchset/20260318193952.47908-1-sanman.pradhan%40hpe.com

It looks like we'll need to add locking for the non-standard attributes
in the driver.

Thanks,
Guenter

> v2:
> - isl68137: Reverted Boolean logic to (val & MASK) == MASK
> - ina233: Added (s16) cast for proper two's complement handling
>
> Sanman Pradhan (2):
>    hwmon: (pmbus/isl68137) Fix unchecked return value and use
>      sysfs_emit()
>    hwmon: (pmbus/ina233) Handle sign extension for negative shunt voltage
>
>   drivers/hwmon/pmbus/ina233.c   | 2 +-
>   drivers/hwmon/pmbus/isl68137.c | 7 +++++--
>   2 files changed, 6 insertions(+), 3 deletions(-)