Re: VFS minor improvements policy

[Jori Koolstra]

> Op 17-03-2026 09:31 CET schreef Jan Kara <jack@xxxxxxx>:
> 
> I guess this is a bit matter of personal preference. I personally would
> prefer explicitely named enum in this case and use it where appropriate but
> Al? apparently preferred brewity and used 'int' everywhere. The borderline
> between "useless typedefs" and "documentation by types" is blurry. I'd say
> trying to "fix" this would do more harm than good.
> 

I understand. I've been traveling a bit through namei.c and open.c, and I come
across quite some things I think may not be quite right. However, I also understand
that I am an idiot, and so it is hard sometimes to judge what to send in :)

For instance, I am quite positive that there is some dead code in the fd allocation
slow path. And I've been puzzled the last two days about nd->depth, and if it can
even ever be > 1. I try sometimes to spar with Claude, but you can just never rely on
it. Just bear with me, and I apologize in advance if I ever send in something silly.
I am just trying to learn.

> 
> If the documentation / comment is pointless or even wrong, that's
> definitely worth a fix. They are just not treated with particularly high
> priority but they are definitely needed.
> 

Noted.

Thanks,
Jori.

> 								Honza
> -- 
> Jan Kara <jack@xxxxxxxx>
> SUSE Labs, CR