Re: [PATCH 1/1 fyi] tools headers: Syncronize linux/build_bug.h with the kernel sources

[Ian Rogers]

nit: Typo in the subject line s/syncronize/synchronize/

On Wed, Mar 18, 2026 at 11:36 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> tldr; Just FYI, I'm carrying this on the perf tools tree.
>
> Full explanation:
>
> There used to be no copies, with tools/ code using kernel headers
> directly. From time to time tools/perf/ broke due to legitimate kernel
> hacking. At some point Linus complained about such direct usage. Then we
> adopted the current model.
>
> See further details at:
>
>  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/include/uapi/README
>
> To pick up the changes in:
>
>   6ffd853b0b10e1e2 ("build_bug.h: correct function parameters names in kernel-doc")
>
> That just add some comments, addressing this perf tools build warning:
>
>   Warning: Kernel ABI header differences:
>     diff -u tools/include/linux/build_bug.h include/linux/build_bug.h
>
> Please take a look at tools/include/uapi/README for further info on this
> synchronization process.
>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> ---
>  include/linux/build_bug.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/build_bug.h b/include/linux/build_bug.h
> index d3dc5dc5f916ff4e..2cfbb4c65c784ad8 100644
> --- a/include/linux/build_bug.h
> +++ b/include/linux/build_bug.h

Shouldn't this patch be to the tools version?

Thanks,
Ian

> @@ -32,8 +32,7 @@
>  /**
>   * BUILD_BUG_ON_MSG - break compile if a condition is true & emit supplied
>   *                   error message.
> - * @cond: the condition which the compiler should know is false.
> - * @msg: build-time error message
> + * @condition: the condition which the compiler should know is false.
>   *
>   * See BUILD_BUG_ON for description.
>   */
> @@ -61,7 +60,6 @@
>
>  /**
>   * static_assert - check integer constant expression at build time
> - * @expr: expression to be checked
>   *
>   * static_assert() is a wrapper for the C11 _Static_assert, with a
>   * little macro magic to make the message optional (defaulting to the
> --
> 2.53.0
>