Re: [PATCH 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with unlock gate

[Rudraksha Gupta]

On 3/7/26 07:46, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 04:58:02PM -0800, Rudraksha Gupta wrote:
> > Some flash ICs use the same one-wire pulse-count protocol as the RT8515
> > but have only a single GPIO line for both flash and torch modes, plus an
> > optional unlock gate (e.g. a PMIC MPP) that must be driven high before
> > the chip responds to the enable GPIO.
> >
> > Make ent-gpios optional and add an unlock-gpios property to support
> > these variants. Add a oneOf constraint requiring exactly one of
> > ent-gpios or unlock-gpios. Add a binding example showing the
> > single-GPIO configuration.
> >
> > Signed-off-by: Rudraksha Gupta <guptarud@xxxxxxxxx>
> > ---
> >   .../devicetree/bindings/leds/richtek,rt8515.yaml   | 36 +++++++++++++++++++++-
> >   1 file changed, 35 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml
> > index 0356371a6b01..820cf8c55090 100644
> > --- a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml
> > +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml
> > @@ -15,6 +15,10 @@ description: |
> >     current for each mode is defined in hardware using two resistors
> >     RFS and RTS.
> >   
> > +  This driver also supports single-GPIO flash ICs that use the same
> Drop reference to driver and explain the hardware here.
>
> > +  one-wire pulse-count protocol on one line for both flash and torch.
> > +  For these, only enf-gpios is required.
> > +
> >   properties:
> >     compatible:
> >       const: richtek,rt8515
> > @@ -26,6 +30,14 @@ properties:
> >     ent-gpios:
> >       maxItems: 1
> >       description: A connection to the 'ENT' (enable torch) pin.
> > +      Optional for single-GPIO flash ICs where enf-gpios is used for
> > +      both flash and torch modes.
> So what happens with ENT GPIO on such boards? How is it connected?

Hello Krzysztof,

Thanks for these comments. I have addressed these in v2

Rudraksha

> Best regards,
> Krzysztof