Re: [PATCH 02/14] iommu: Implement IOMMU core liveupdate skeleton

[Samiullah Khawaja]

On Tue, Mar 17, 2026 at 08:23:38PM +0000, Pranjal Shrivastava wrote:
> On Tue, Mar 17, 2026 at 08:13:47PM +0000, Samiullah Khawaja wrote:
> > On Tue, Mar 17, 2026 at 08:09:26PM +0000, Pranjal Shrivastava wrote:
> > > On Fri, Mar 13, 2026 at 06:42:05PM +0000, Samiullah Khawaja wrote:
> > > > On Thu, Mar 12, 2026 at 11:10:36PM +0000, Pranjal Shrivastava wrote:
> > > > > On Tue, Feb 03, 2026 at 10:09:36PM +0000, Samiullah Khawaja wrote:
> > > > > > +EXPORT_SYMBOL(iommu_get_preserved_data);
> > > > > > +
> > >
> > > Also, I don't see these helpers being used anywhere in this series yet?
> > > Should we add them with the phase-2 series? When we actually "Restore"
> > > the domain?
> >
> > Phase 1 does restore the iommu and domains during boot. But the
> > iommufd/hwpt state is not restored or re-associated with the restored
> > domains.
> >
> > These helpers are used to fetch the preserved state during boot.
> >
> > Thanks,
> > Sami
>
> I see these are used in PATCH 8, should we introduce these helpers in
> PATCH 8 where we actually use them? As we introduce iommu_restore_domain
> in PATCH 8?

Agreed. I will move the helper for getting the device state into PATCH
8. But the one that is used to fetch the iommu state is used by the vt-d
driver in the PATCH 7. I will add a new patch before PATCH 7 to add that
helper.

Thanks,
Sami
> Thanks,
> Praan