Re: [PATCH 2/2] staging: rtl8723bs: add parentheses around macro arguments

[Greg KH]

On Wed, Mar 18, 2026 at 06:35:15PM +0300, Hüseyin Can Erdem wrote:
> Add parentheses around macro arguments in IS_FW_HEADER_EXIST_8723B
> and AVAILABLE_EFUSE_ADDR to avoid potential operator precedence issues.
> 
> Signed-off-by: Hüseyin Can Erdem <erdemhuseyincan09@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
> index 32a93653b..cd3b49338 100644
> --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
> +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
> @@ -28,7 +28,7 @@
>  #define FW_8723B_END_ADDRESS   0x1FFF /* 0x5FFF */
>  
>  #define IS_FW_HEADER_EXIST_8723B(fw_hdr) \
> -	((le16_to_cpu(fw_hdr->signature) & 0xFFF0) == 0x5300)
> +	((le16_to_cpu((fw_hdr)->signature) & 0xFFF0) == 0x5300)
>  
>  struct rt_firmware {
>  	u32 fw_length;
> @@ -133,7 +133,7 @@ struct rt_firmware_hdr {
>  #define EFUSE_IC_ID_OFFSET 506 /* For some inferiority IC purpose.
>  				* Added by Roger, 2009.09.02.
>  				*/
> -#define AVAILABLE_EFUSE_ADDR(addr) (addr < EFUSE_REAL_CONTENT_LEN_8723B)
> +#define AVAILABLE_EFUSE_ADDR(addr) ((addr) < EFUSE_REAL_CONTENT_LEN_8723B)
>  
>  #define EFUSE_ACCESS_ON  0x69 /* For RTL8723 only. */
>  #define EFUSE_ACCESS_OFF 0x00 /* For RTL8723 only. */
> -- 
> 2.47.3
> 
> 

Please slow down, there is no rush here.  Take at least a day before
sending a new version of a patch.

Also, why was this not marked as a "v2" or "v3" or whatever it really
is?

thanks,

greg k-h