Re: [PATCH 2/3] drm/msm/dsi: Add support for RGB101010 pixel format
From: Dmitry Baryshkov
Date: Wed Mar 18 2026 - 11:23:40 EST
On Wed, Mar 18, 2026 at 09:41:05AM +0000, Alexander Koskovich wrote:
> Add video and command mode destination format mappings for
> RGB101010, and extend the VID_CFG0 DST_FORMAT bitfield to 3 bits
> to accommodate the new format value.
It's only available since DSI 6G 2.1.0. Could you please add the
corresponding check (I think having something like .has_rgb30 as a part
of struct msm_dsi_config is a good enough approach).
>
> Required for 10 bit panels such as the BOE BF068MWM-TD0.
>
> Signed-off-by: Alexander Koskovich <akoskovich@xxxxx>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
> drivers/gpu/drm/msm/registers/display/dsi.xml | 4 +++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index db6da99375a1..3e3d61b9390f 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -757,6 +757,7 @@ static inline enum dsi_vid_dst_format
> dsi_get_vid_fmt(const enum mipi_dsi_pixel_format mipi_fmt)
> {
> switch (mipi_fmt) {
> + case MIPI_DSI_FMT_RGB101010: return VID_DST_FORMAT_RGB101010;
> case MIPI_DSI_FMT_RGB888: return VID_DST_FORMAT_RGB888;
> case MIPI_DSI_FMT_RGB666: return VID_DST_FORMAT_RGB666_LOOSE;
> case MIPI_DSI_FMT_RGB666_PACKED: return VID_DST_FORMAT_RGB666;
> @@ -769,6 +770,7 @@ static inline enum dsi_cmd_dst_format
> dsi_get_cmd_fmt(const enum mipi_dsi_pixel_format mipi_fmt)
> {
> switch (mipi_fmt) {
> + case MIPI_DSI_FMT_RGB101010: return CMD_DST_FORMAT_RGB101010;
> case MIPI_DSI_FMT_RGB888: return CMD_DST_FORMAT_RGB888;
> case MIPI_DSI_FMT_RGB666_PACKED:
> case MIPI_DSI_FMT_RGB666: return CMD_DST_FORMAT_RGB666;
> diff --git a/drivers/gpu/drm/msm/registers/display/dsi.xml b/drivers/gpu/drm/msm/registers/display/dsi.xml
> index c7a7b633d747..7636e9914078 100644
> --- a/drivers/gpu/drm/msm/registers/display/dsi.xml
> +++ b/drivers/gpu/drm/msm/registers/display/dsi.xml
> @@ -15,6 +15,7 @@ xsi:schemaLocation="https://gitlab.freedesktop.org/freedreno/ rules-fd.xsd">
> <value name="VID_DST_FORMAT_RGB666" value="1"/>
> <value name="VID_DST_FORMAT_RGB666_LOOSE" value="2"/>
> <value name="VID_DST_FORMAT_RGB888" value="3"/>
> + <value name="VID_DST_FORMAT_RGB101010" value="4"/>
> </enum>
> <enum name="dsi_rgb_swap">
> <value name="SWAP_RGB" value="0"/>
> @@ -39,6 +40,7 @@ xsi:schemaLocation="https://gitlab.freedesktop.org/freedreno/ rules-fd.xsd">
> <value name="CMD_DST_FORMAT_RGB565" value="6"/>
> <value name="CMD_DST_FORMAT_RGB666" value="7"/>
> <value name="CMD_DST_FORMAT_RGB888" value="8"/>
> + <value name="CMD_DST_FORMAT_RGB101010" value="9"/>
> </enum>
> <enum name="dsi_lane_swap">
> <value name="LANE_SWAP_0123" value="0"/>
> @@ -142,7 +144,7 @@ xsi:schemaLocation="https://gitlab.freedesktop.org/freedreno/ rules-fd.xsd">
> </reg32>
> <reg32 offset="0x0000c" name="VID_CFG0">
> <bitfield name="VIRT_CHANNEL" low="0" high="1" type="uint"/> <!-- always zero? -->
> - <bitfield name="DST_FORMAT" low="4" high="5" type="dsi_vid_dst_format"/>
> + <bitfield name="DST_FORMAT" low="4" high="6" type="dsi_vid_dst_format"/>
Please comment that it had high=5 before DSI 6G 2.1.0
> <bitfield name="TRAFFIC_MODE" low="8" high="9" type="dsi_traffic_mode"/>
> <bitfield name="BLLP_POWER_STOP" pos="12" type="boolean"/>
> <bitfield name="EOF_BLLP_POWER_STOP" pos="15" type="boolean"/>
>
> --
> 2.53.0
>
>
--
With best wishes
Dmitry