Re: [PATCH] staging: greybus: replace DEFINE_IDR with DEFINE_XARRAY_ALLOC in uart.c
From: Greg KH
Date: Wed Mar 18 2026 - 10:59:22 EST
On Wed, Mar 18, 2026 at 03:36:03PM +0100, Johan Hovold wrote:
> On Wed, Mar 18, 2026 at 03:20:20PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 17, 2026 at 10:16:51PM +0100, Oskar Ray-Frayssinet wrote:
> > > Replace deprecated DEFINE_IDR and idr_* functions with the modern
> > > DEFINE_XARRAY_ALLOC and xa_* equivalents in the greybus uart driver.
> >
> > What tool is causing people to want to do this change that I keep
> > rejecting? Can you please go and fix it?
>
> It's checkpatch:
>
> WARNING: Deprecated use of 'DEFINE_IDR', prefer 'DEFINE_XARRAY' instead
> #70: FILE: drivers/staging/greybus/uart.c:70:
> +static DEFINE_IDR(tty_minors);
Ugh, that should be changed to only trigger that warning on a patch, not
on an existing file.
thanks,
greg k-h