Re: [PATCH] i3c: fix missing newline in dev_err messages
From: Frank Li
Date: Wed Mar 18 2026 - 10:36:02 EST
On Tue, Mar 17, 2026 at 11:40:15AM +0800, Haoyu Lu wrote:
> From: "haoyu.lu" <hechushiguitu666@xxxxxxxxx>
>
> Add missing newline to dev_err messages in:
> - drivers/i3c/master.c
> - drivers/i3c/master/svc-i3c-master.c
>
> Signed-off-by: haoyu.lu <hechushiguitu666@xxxxxxxxx>
> ---
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> drivers/i3c/master.c | 2 +-
> drivers/i3c/master/svc-i3c-master.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 9e6be49bebb2..27e93fcf2eba 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2396,7 +2396,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
> * DEFSLVS command.
> */
> if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> - dev_err(dev, "I2C device with 10 bit address not supported.");
> + dev_err(dev, "I2C device with 10 bit address not supported.\n");
> return -EOPNOTSUPP;
> }
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index b84b324e4111..e09a6218bf34 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1268,7 +1268,7 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
> /* Configure IBI auto-rules */
> ret = svc_i3c_update_ibirules(master);
> if (ret)
> - dev_err(master->dev, "Cannot handle such a list of devices");
> + dev_err(master->dev, "Cannot handle such a list of devices\n");
>
> rpm_out:
> pm_runtime_put_autosuspend(master->dev);
> --
> 2.53.0.windows.1
>