Re: [PATCH v4] rust: block: rnull: update to Pin<KBox<QueueData>> for PinInit
From: Andreas Hindborg
Date: Wed Mar 18 2026 - 09:07:54 EST
Adrián García Casado <adriangarciacasado42@xxxxxxxxx> writes:
> Utilize the pin_init! macro for QueueData initialization to correctly support in-place initialization patterns. This aligns the driver with standard Rust-for-Linux pinning practices for driver-specific queue data.
>
> Signed-off-by: Adrián García Casado <adriangarciacasado42@gmailcom>
I don't understand the rationale for this patch. I already have a patch
on list that pins `QueueData` for rnull [1], but not for the reasons you
mention here. `QueueData` does not need to be pinned if it does not have
any fields of types that must always be pinned.
Best regards,
Andreas Hindborg
[1] https://lore.kernel.org/r/20260216-rnull-v6-19-rc5-send-v1-13-de9a7af4b469@xxxxxxxxxx