Re: [PATCH] crypto: caam - remove HMAC key hex dumps from hash_digest_key

From: Thorsten Blum

Date: Wed Mar 18 2026 - 08:30:59 EST


On Wed, Mar 18, 2026 at 09:16:02PM +0900, Herbert Xu wrote:
> On Wed, Mar 18, 2026 at 01:02:11PM +0100, Thorsten Blum wrote:
> >
> > My main concern is that with CONFIG_DYNAMIC_DEBUG enabled, which doesn't
> > require DEBUG, these raw key dumps can still be turned on at runtime in
> > a deployed kernel.
> >
> > If we want to keep the dumps for debug-only kernels, then #ifdef DEBUG
> > plus print_hex_dump() might be a good compromise.
>
> Exactly. Having sensitive information printed with DYNAMIC_DEBUG
> is arguably a problem, but putting them behind DEBUG is definitely
> OK.

Ok, thanks. I'll send a v2 soon using print_hex_dump() guarded by
#ifdef DEBUG.