Re: [PATCH 01/13] scsi: scsi_dh_alua: Delete alua_port_group

[John Garry]

On 18/03/2026 07:44, Hannes Reinecke wrote:
> On 3/17/26 13:06, John Garry wrote:
> > Delete the alua_port_group usage, as it is more accurate to manage the
> > port group info per-scsi device - see [0]
> >
> > [0] https://urldefense.com/v3/__https://lore.kernel.org/linux- 
> > scsi/20260310114925.1222263-1-john.g.garry@xxxxxxxxxx/T/ 
> > *m4ffc0d07f169b70b8fd2407bae9632aa0f8c1f9a__;Iw!!ACWV5N9M2RV99hQ! 
> > L3ooFRT-lbVw- 
> > vEOYnh_4z9auyqWLGG4U8lhysEdtpLWZCp5ReAn77SF2Tnr4nxHbv7zdsG9q6NxhWw$
> > For now, the handler data will be used to hold the ALUA-related info.
> >
> > Signed-off-by: John Garry <john.g.garry@xxxxxxxxxx>
> > ---
> >   drivers/scsi/device_handler/scsi_dh_alua.c | 663 ++++++---------------
> >   1 file changed, 180 insertions(+), 483 deletions(-)
> In principle, yes, but I would put this at the end after the patches to
> move the alua functionality to the scsi core.

The alua_port_group functionality is intertwined with all the ALUA 
handling, so it is hard to start to separate out (from scsi_dh_alua.c) 
and then remove it. Furthermore, it would just be duplicating what we 
have in sdev->alua structure.