Re: [PATCH v3 12/12] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE

From: Krzysztof Kozlowski

Date: Wed Mar 18 2026 - 03:36:02 EST


On 17/03/2026 10:20, Harshal Dev wrote:
> Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver
> de-coupled from the QCOM UFS driver, it explicitly votes for its required
> clocks during probe. For scenarios where the 'clk_ignore_unused' flag is
> not passed on the kernel command line, to avoid potential unclocked ICE
> hardware register access during probe the ICE driver should additionally
> vote on the 'iface' clock.
> Also update the suspend and resume callbacks to handle un-voting and voting
> on the 'iface' clock.
>
> Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver")
> Signed-off-by: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>
> ---
> drivers/soc/qcom/ice.c | 17 +++++++++++++++--

Why the driver patch is after the DTS patches? It is explicitly
documented as no-go.

You do not understand how patches are being applied and you think you
can fix inherent problems in bisectability by creating incorrect order
of patches. No, you cannot. Read maintainer soc profile and entire
development-process document, so you understand how patches are applied,
what are branches, what is current RC and how kernel is effectively
released.

Best regards,
Krzysztof