Re: [PATCH v6 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub

[Krzysztof Kozlowski]

On Wed, Mar 18, 2026 at 09:36:41AM +0530, Swati Agarwal wrote:

A nit, subject: drop second/last, redundant "binding fir". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>    reg: true
> @@ -26,6 +27,10 @@ properties:
>      description:
>        The regulator that provides 3.3V or 5.0V core power to the hub.
>  
> +  vdd12-supply:
> +    description:
> +      The regulator that provides 1.2V power to the hub.
> +
>    peer-hub: true
>  
>    ports:
> @@ -69,6 +74,17 @@ allOf:
>          peer-hub: true
>          vdd-supply: true

Here and in other cases you forgot to forbid new property (: false).

Best regards,
Krzysztof