Re: [PATCH v7 18/31] gpu: nova-core: add MCTP/NVDM protocol types for firmware communication

[John Hubbard]

On 3/17/26 3:53 PM, John Hubbard wrote:
...
> +bitfield! {
> +    pub(crate) struct MctpHeader(u32), "MCTP transport header for NVIDIA firmware messages." {
> +        31:31 som as bool, "Start-of-message bit.";
> +        30:30 eom as bool, "End-of-message bit.";
> +        29:28 seq as u8, "Packet sequence number.";
> +        23:16 seid as u8, "Source endpoint ID.";

hmmm, I seem to remember my very slightly younger self insisting
that fields be listed from lowest to highest bits. And now I've
violated that in both headers in this patch. arghh

I'll fix it if there is a v8 required.

thanks,
-- 
John Hubbard